Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][IIS] Migrate Webserver Process Overview dashboard visualizations to lens in kibana 8.5.0 #5725

Merged
merged 4 commits into from
Apr 13, 2023
Merged

[O11y][IIS] Migrate Webserver Process Overview dashboard visualizations to lens in kibana 8.5.0 #5725

merged 4 commits into from
Apr 13, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 29, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for IIS integration package

  • Statistics for IIS Lens migration:

IIS dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics IIS] Webserver Process Overview 0 12 11 1
  0 12 11 1

Note: 1 markdown panel has not been migrated because we don't have any alternatives in lens for markdown.
1-metricbeat-iis-application-pool-overview

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 29, 2023 05:14
@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T07:29:36.740+0000

  • Duration: 14 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35) ❕
Lines 93.772% (271/289) ❕
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 29, 2023
Closed
9 tasks
@kush-elastic kush-elastic added enhancement New feature or request v8.5.0 Team:Service-Integrations Label for the Service Integrations team Integration:iis IIS labels Mar 29, 2023
kush-elastic
kush-elastic approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
a3cf9ba 
…s_migration-iis-webserver-process-overview-8.5.0
@kush-elastic kush-elastic merged commit 890f20c into elastic:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:iis IIS Team:Service-Integrations Label for the Service Integrations team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajvi-patel-22 @elasticmachine @kush-elastic @agithomas